Fix bug where cloned Neo/Matrix blocks get incorrect LJ Color Picker field values #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a bug in the field's
getInputHtml()method, where the field value is set to the default colour if$this->isFresh($element)is true, regardless of whether the$valuepassed intogetInputHtml()is set or not. Not also checking whether$value === nullcauses pasted/cloned Neo blocks, and Matrix blocks pasted/cloned using Smith, to have the default colour set on the clone block instead of the colour value from the block that was copied/cloned. This pull request ensures that$value === nullis checked.Fixes #1.