Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Eclipse build fails in master #1436

Closed
edwardalee opened this issue Oct 31, 2022 · 1 comment · Fixed by #1440
Closed

Eclipse build fails in master #1436

edwardalee opened this issue Oct 31, 2022 · 1 comment · Fixed by #1440
Assignees
Labels
bug Something isn't working build system

Comments

@edwardalee
Copy link
Collaborator

Eclipse build fails in master because CliBase.java, LFStandaloneModule.java, Lfc.java, and other classes reference ReportingUtil.kt. Does that class have to be Kotlin?

There is also this error:

Description Resource Path Location Type
Bundle 'org.lflang.epoch.external.dependencies' cannot be resolved MANIFEST.MF /org.lflang/META-INF line 19 Plug-in Problem

@edwardalee edwardalee added bug Something isn't working build system labels Oct 31, 2022
@cmnrd
Copy link
Collaborator

cmnrd commented Nov 1, 2022

This class does not have to be Kotlin (non of our classes have to). But I would consider converting it back to Java a step backwards.

This issue was caused by merging #1422. This PR integrates the contents of org.lflang.cli into org.lflang as a first step for simplifying our source tree layout (see #1276). I think the problem occurs now, because Eclipse simply did not compile org.lflang.cli before since it is not needed for Epoch.

Since the cli subpackage is not used by Epoch, my proposal is to exclude it from the source list in the Eclipse configuration. Should this not work for some reason, I would propose to convert all classes in cli to Kotlin, as then they are effectively ignored by Eclipse.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working build system
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants