-
-
Notifications
You must be signed in to change notification settings - Fork 63
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New lff autoformatter for Lingua Franca files #1422
Conversation
Haha, @cmnrd is faster than me on this…… I’ll review this PR then |
Still some open tasks though!
|
the --run option is dropped because it would be unclear which command to run
@axmmisaka Do you have access to a Windows machine? You could fix the lfc.ps1 script and add a similar one for lff |
Yes! I’ll take care of it |
Just as a reminder things like this needs to be changed as well |
|
78fe421
to
0b9bb2e
Compare
PowerShell scripts for lfc and lff
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚀 🚀 🚀
As far as I am concerned this is ready to be merged! The only point that is still unclear to me is whether the changes here affect the release toolflow. @lhstrh can you comment on this and perhaps open an issue in the workflow repo? |
There might be some issue, but those will surface once I create a draft PR. This should not be a reason to hold up this PR and would only amount to changes required in the |
org.lflang.cli
as a subpackage into org.lflang
org.lflang.cli
moved into org.lflang
as subpackage
org.lflang.cli
moved into org.lflang
as subpackage
This PR refactors the org.lflang.cli package.
org.lflang.cli
package as a subpackage inorg.lflang
. This closes Move contents oforg.lflang.lfc
to a subpackagelfc
withinorg.lflang
#1421.org.lflang-0.3.1-SNAPSHOT.jar
) is created. This jar includes both the lfc and lff main classes. The main build task is now calledbuildAll
.buildLfc
is still available but shows a deprecation warning.lff
script to invoke the lingua franca formatter. This closes Createlff
script #1369.build-lf-cli
and drops the--run
option. Note that the old build script is still available, but prints a deprecation warning. The--run
option was dropped because it would be unclear which command to run. Also the run tasks that we provide for gradle already implement this functionality.There are still a couple of unresolved issues though:
build-lfc
script. Should we name itbuild-all
?lff.ps1
script for Windows. (@axmmisaka)org.lflang.cli.test
, but I was not able to move it to the new location and make it work with gradle. @oowekyala can you help with this?buildAll
task instead ofbuildLfc
. Alsobuild-lf-cli
should be used instead ofbuild-lfc
. See Update the developer documentation to use the build-lf-cli script and the buildAll gradle task lf-lang.github.io#106.github/scripts/package_lfc.sh
script (and rename topackage.sh
?)