Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handling of target properties in the C code generator is problematic #2083

Closed
lhstrh opened this issue Nov 5, 2023 · 0 comments · Fixed by #2232
Closed

Handling of target properties in the C code generator is problematic #2083

lhstrh opened this issue Nov 5, 2023 · 0 comments · Fixed by #2232

Comments

@lhstrh
Copy link
Member

lhstrh commented Nov 5, 2023

The C code generator creates a separate target config for each imported file and uses it specifically to handle the cmake-include and files target property, but ignores everything else. See CGenerator.inspectReactorEResource and GeneratorUtils.getLFResource.

Moreover, FederateGenerator implements a redundant but similarly ad-hoc handling of target properties from imported files (see #2080).

Instead, we should build a single TargetConfig and let the TargetProperty classes specify what the update behavior should be (e.g., override, append, etc.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant