Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Timeout should not be inherited #2149

Closed
Tracked by #2232
edwardalee opened this issue Jan 10, 2024 · 1 comment · Fixed by #2232
Closed
Tracked by #2232

Timeout should not be inherited #2149

edwardalee opened this issue Jan 10, 2024 · 1 comment · Fixed by #2232
Assignees
@lhstrh
Labels
bug Something isn't working
Milestone
0.8.0

Comments

@edwardalee
Copy link
Collaborator

It appears that if you import a reactor from another file, you inherit the timeout target property from that file. This should not be the case.
@edwardalee edwardalee added the bug Something isn't working label Jan 10, 2024
@lhstrh lhstrh self-assigned this Jan 23, 2024
@lhstrh lhstrh added this to the 0.7.0 milestone Jan 30, 2024
@lhstrh
Copy link
Member

lhstrh commented Feb 17, 2024

Related to #2083.

@byeonggiljun byeonggiljun linked a pull request Mar 4, 2024 that will close this issue
Bugfixes in handling of target properties across imports #2232
Merged
3 tasks
@lhstrh lhstrh modified the milestones: 0.7.0, 0.8.0 Apr 27, 2024
@cmnrd cmnrd modified the milestones: 0.8.0, 0.9.0 Jun 17, 2024
@lhstrh lhstrh mentioned this issue Jun 30, 2024
Merged
3 tasks
@lhstrh lhstrh closed this as completed Jun 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lhstrh lhstrh

Labels
bug Something isn't working
Projects
None yet
Milestone
0.8.0
Development

Successfully merging a pull request may close this issue.

Bugfixes in handling of target properties across imports lf-lang/lingua-franca
3 participants
@cmnrd @edwardalee @lhstrh