Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DistributedPhysicalActionUpstreamLong.lf times out in mac CI #2254

Closed
erlingrj opened this issue Apr 4, 2024 · 4 comments
Closed

DistributedPhysicalActionUpstreamLong.lf times out in mac CI #2254

erlingrj opened this issue Apr 4, 2024 · 4 comments
Labels
bug Something isn't working c Related to C target ci Continuous integration federated mac Related to the Apple MacOS platform

Comments

@erlingrj
Copy link
Collaborator

erlingrj commented Apr 4, 2024

We are having problems with DistributedPhysicalActionUpstreamLong.lf timing out in CI, e.g. here. I have also seen it in another unrelated PR, so it is not about the changes introduced there.

I am not sure what could have introduced this. A hint might be that @petervdonovan merged in #2249 , however it should not affect this because that was Docker-specific.

@erlingrj erlingrj added bug Something isn't working c Related to C target mac Related to the Apple MacOS platform federated ci Continuous integration labels Apr 4, 2024
@erlingrj erlingrj changed the title DistributedPhysicalActionUpstreamLong.lf timing out on macOS DistributedPhysicalActionUpstreamLong.lf times out in mac CI Apr 4, 2024
@petervdonovan
Copy link
Collaborator

Unless the way timeouts work in our test framework has changed, the CI run that you linked looks like a user cancellation, not a timeout.

@lhstrh
Copy link
Member

lhstrh commented Apr 4, 2024

Timeout is set to 120 mins

@erlingrj
Copy link
Collaborator Author

erlingrj commented Apr 5, 2024

I reran with logging enabled, and now it seems to have timed out on a different test: https://github.com/lf-lang/reactor-c/actions/runs/8546664692/job/23459617885?pr=400

@lhstrh
Copy link
Member

lhstrh commented Apr 5, 2024

There is a history of the compiler getting stuck on macOS. We don't know why this happens and it doesn't seem to be reproducible. It was assumed that the culprit was here:

6, Math.min(Math.max(federates.size(), 1), Runtime.getRuntime().availableProcessors()));

But in hindsight, I don't think we ever actually solved the problem...

@lhstrh lhstrh closed this as completed Apr 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working c Related to C target ci Continuous integration federated mac Related to the Apple MacOS platform
Projects
None yet
Development

No branches or pull requests

3 participants