Fix in error handling for Docker builds #2249
Conversation
We were always returning false for whether errors occurred in federated docker builds, but we should be checking the context to see whether an error was reported.
petervdonovan
force-pushed
the
fix-docker-error-handling
branch
from
6a30157
to
9fff2a7
Compare
|
By the way, there is also a problem in Technically things are OK now because the test framework does not mark failing tests as passing anymore, but maybe I should open an issue about this. |
There was a problem hiding this comment.
These changes look great! Thanks for these much-needed fixes, @petervdonovan. Is there a PR in reactor-c that corresponds to the changes included in lf-lang/reactor-c@7427d98...2a3c257?
|
It looks like there are still unaddressed failures also: https://github.com/lf-lang/lingua-franca/actions/runs/8406281187/job/23019999735?pr=2249 |
Note how non-obvious it is that this is a bug or even why the fix works. This is a consequence of reliance on implicit reliance on big chunks of shared mutable state. The resource is modified; the context is computed from the resource; therefore, the resource has to be modified before the context is computed.
We were always returning false for whether errors occurred in federated docker builds, but we should be checking the context to see whether an error was reported.