Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Grammar cleanup #1008

Merged
merged 3 commits into from
Mar 8, 2022
Merged

Grammar cleanup #1008

merged 3 commits into from
Mar 8, 2022

Conversation

cmnrd
Copy link
Collaborator

@cmnrd cmnrd commented Mar 8, 2022

This PR deletes various grammar rules that are not used.

Note: The Expr rule seems useful, but making it work requires some effort. We will introduce expressions as part of #544.

edwardalee
edwardalee approved these changes Mar 8, 2022
View reviewed changes
Copy link
Collaborator

@edwardalee edwardalee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@cmnrd cmnrd merged commit fcc7733 into master Mar 8, 2022
@cmnrd cmnrd deleted the grammar-cleanup branch March 8, 2022 15:48
@lhstrh lhstrh mentioned this pull request Mar 17, 2022
Closed
@lhstrh lhstrh added the refactoring Code quality enhancement label Mar 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@edwardalee edwardalee edwardalee approved these changes

@Soroosh129 Soroosh129 Awaiting requested review from Soroosh129

@lhstrh lhstrh Awaiting requested review from lhstrh

Assignees
No one assigned
Labels
refactoring Code quality enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@cmnrd @edwardalee @lhstrh