Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve Stability of Positioning Edges connected to Reactions in Diagrams #1040

Merged
merged 2 commits into from
Mar 14, 2022

Conversation

a-sr
Copy link
Collaborator

@a-sr a-sr commented Mar 14, 2022

If a reaction has multiple input/output dependencies, sometimes the edges do not properly end at the border of the shape but the bounding box. This PR fixes this issue for most (or at least more) cases.

Also fixes the 'bundle dependencies' synthesis option for reactions that was broken in the translation from xtend to java.

@a-sr a-sr requested a review from lhstrh March 14, 2022 14:22
Copy link
Collaborator

@edwardalee edwardalee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, except that the indentation in these files is wonky, which makes the GitHub diffs very hard to read. Looks like there is a mix of tabs and spaces in the files.

@a-sr
Copy link
Collaborator Author

a-sr commented Mar 14, 2022

The indentation is indeed very inconsistent throughout the entire diagram package.
I will create a separate PR with all tabs converted to spaces or should I include it in this one?

@lhstrh
Copy link
Member

lhstrh commented Mar 14, 2022

The indentation is indeed very inconsistent throughout the entire diagram package. I will create a separate PR with all tabs converted to spaces or should I include it in this one?

Let's fix indentation in a separate PR for the sake of readability of the diff. I'll go ahead and merge this as is.

@lhstrh lhstrh merged commit 09beff1 into master Mar 14, 2022
@lhstrh lhstrh added the enhancement Enhancement of existing feature label Mar 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Enhancement of existing feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants