Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optionally suppress the red No Main Reactor icon #1089

Merged
merged 1 commit into from
Apr 19, 2022

Conversation

edwardalee
Copy link
Collaborator

When creating figures for web pages and papers, it is inconvenient to have the "No Main Reactor" icon in red. I have to edit it out of the SVG file. This PR suppresses that icon if "All Reactors" is selected.

@edwardalee edwardalee requested a review from a-sr April 11, 2022 17:41
@lhstrh lhstrh added the enhancement Enhancement of existing feature label Apr 11, 2022
Copy link
Collaborator

@a-sr a-sr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, this is a reasonable change.

In case you ever want to only export a specific part of the diagram without post-processing, you can also use the "Clip towards selecting" entry in the context menu of a selected diagram element, this will focus the view and also affects export. However, I think this is only supported in Epoch and not a real replacement for the change in this PR.

@cmnrd cmnrd merged commit 66c59d1 into master Apr 19, 2022
@cmnrd cmnrd deleted the diagram-suppress-no-main branch April 19, 2022 13:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Enhancement of existing feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants