Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix whitespace in tests #1183

Merged
merged 4 commits into from
May 19, 2022
Merged

Fix whitespace in tests #1183

merged 4 commits into from
May 19, 2022

Conversation

petervdonovan
Copy link
Collaborator

LSP tests failed in the expressions branch (again!), this time because of mixed spaces and tabs. This style violation caused ESLint to throw an error, which ended compilation (tsc was not even executed, so no type checking). This prevented the TypeScript validator from catching the error that it was expected to catch.

I would like to merge this directly into @cmnrd's expressions branch, since that one will soon go into master anyway.

This pass was automated instead of manual. It replaces carriage return/line feed line terminators with just line feed terminators, and it removes trailing whitespace.
This is a manual pass for incorrect indentation.
Copy link
Member

@lhstrh lhstrh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Holy cow! This is quite the diff! Assuming that this indeed only concerns white space changes, this looks good to me :-)

It would be great to have checks for the formatting of LF code as part of CI to avoid problems like these in the future.

@petervdonovan petervdonovan merged commit 1e8cbc5 into expressions May 19, 2022
@cmnrd cmnrd deleted the tests-fix-whitespace branch March 10, 2023 15:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants