Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Diagram layout improvements #1206

Merged
merged 8 commits into from
Jun 22, 2022
Merged

Diagram layout improvements #1206

merged 8 commits into from
Jun 22, 2022

Conversation

a-sr
Copy link
Collaborator

@a-sr a-sr commented May 31, 2022

Increase ELK version to latest release and activates new layout features.

@a-sr a-sr added the diagrams Problems with diagram synthesis label May 31, 2022
@a-sr
Copy link
Collaborator Author

a-sr commented Jun 15, 2022

All planned changes are implemented. PR is ready for review.

@a-sr a-sr marked this pull request as ready for review June 15, 2022 11:51
@lhstrh
Copy link
Member

lhstrh commented Jun 15, 2022

Looks like we're still stuck with a Maven configuration that doesn't work...

Copy link
Member

@lhstrh lhstrh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks excellent and ready to merge in, except for the missing Javadoc...

Copy link
Member

@lhstrh lhstrh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀 🚀 🚀

@lhstrh lhstrh changed the title Layout improvements Diagram layout improvements Jun 22, 2022
@lhstrh lhstrh merged commit f098edc into master Jun 22, 2022
@lhstrh lhstrh deleted the diagrams branch June 22, 2022 08:27
@lhstrh lhstrh added the enhancement Enhancement of existing feature label Jun 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
diagrams Problems with diagram synthesis enhancement Enhancement of existing feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants