Added advance-message-interval option and more federated tests for TypeScript #1293
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hokeun
changed the title
…, as it now supports advance-message-interval.
|
NOTE 1: I think this change shouldn't cause any merge conflict on the fed-gen PR: #1221 NOTE 2: This is a bug fix for reactor-ts runtime |
Soroosh129
approved these changes
Jul 24, 2022
| targetConfig.coordinationOptions.advance_message_interval != null) { | ||
| targetConfigurations.add( | ||
| "this.setAdvanceMessageInterval(${timeInTargetLanguage(targetConfig.coordinationOptions.advance_message_interval)})") | ||
| } |
There was a problem hiding this comment.
I think there should be a warning here if advance_message_interval is not set by the user. At least this is how this scenario is handled in C and Python.
There was a problem hiding this comment.
Thank you for the suggestion! I added a warning here: 1c6a598
…t for reactor but advance message interval is not set.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relevant reactor-ts PR: lf-lang/reactor-ts#109