Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix to ensure the ordering of reactions relative to modes is correct #1303

Merged
merged 2 commits into from
Jul 21, 2022

Conversation

a-sr
Copy link
Collaborator

@a-sr a-sr commented Jul 21, 2022

Fixes ordering of reactions if placed between or after modes.

Closes #1301

@a-sr a-sr marked this pull request as ready for review July 21, 2022 14:06
@a-sr a-sr requested a review from edwardalee July 21, 2022 14:08
Copy link
Collaborator

@edwardalee edwardalee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for fixing this.

@lhstrh lhstrh changed the title Fix ordering of reactions relative to modes Fix to ensure the ordering of reactions relative to modes is correct Jul 21, 2022
@lhstrh lhstrh merged commit 1a800a9 into master Jul 21, 2022
@cmnrd cmnrd deleted the modal-models branch March 10, 2023 15:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Reactions outside modes are ordered incorrectly relative to those inside modes.
3 participants