Quick fix to adjust upstreamFedDelays as never tag #1334
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@lhstrh Can you tell me your opinion about merging this PR to approving this reactor-ts PR, although it isn't a fundamental solution? If you agree to merge this PR, I'll change this pull request to ready. |
OK, makes sense! |
lhstrh
approved these changes
Aug 24, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relevant issue: lf-lang/reactor-ts#118
Relevant reactor-ts PR: lf-lang/reactor-ts#120
This is not a fundamental solution to solve the issue above.
But it makes the federated execution in TypeScript more properly compared to before.