-
-
Notifications
You must be signed in to change notification settings - Fork 63
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Removal of PyDev and Kotlin plugin dependencies from Epoch #1371
Conversation
@a-sr: removal of the Kotlin plugin is causing compile errors in the Maven build. Could we just introduce the dependency through Maven rather than Tycho? |
Also tagging @oowekyala for help on this. |
I am not sure if that is possible because Kotlin is a runtime dependency and Eclipse only accepts plugins in its runtime. We could try to pull the dependency via maven central and then put it on the plugin's classpath but I have the feeling that we already tried that in the past and it was problematic. One thing I am certain of is that it will complicate the build process in the Eclipse IDE because Eclipse does not like to mix maven and eclipse dependencies in the same project. |
OK, thanks for looking into this, @a-sr. It sounds like there is no way to properly support Epoch on macOS then, because code signing won't work if the Kotlin plugin is included, and building Epoch won't work without the Kotlin plugin. |
This reverts commit 303f883.
This reverts commit b1c64c2.
Confirmed that this doesn't impair the code generators that are written in Kotlin. |
Attempt to address code signing issues discussed in lf-lang/epoch#10