Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removal of PyDev and Kotlin plugin dependencies from Epoch #1371

Merged
merged 9 commits into from
Oct 1, 2022

Conversation

lhstrh
Copy link
Member

@lhstrh lhstrh commented Sep 17, 2022

Attempt to address code signing issues discussed in lf-lang/epoch#10

@lhstrh lhstrh requested a review from a-sr September 17, 2022 06:13
@lhstrh lhstrh changed the title Removed PyDev and Kotlin plugin dependencies from Epoch Removal of PyDev and Kotlin plugin dependencies from Epoch Sep 17, 2022
@lhstrh
Copy link
Member Author

lhstrh commented Sep 17, 2022

@a-sr: removal of the Kotlin plugin is causing compile errors in the Maven build. Could we just introduce the dependency through Maven rather than Tycho?

@lhstrh
Copy link
Member Author

lhstrh commented Sep 17, 2022

Also tagging @oowekyala for help on this.

@a-sr
Copy link
Collaborator

a-sr commented Sep 20, 2022

@a-sr: removal of the Kotlin plugin is causing compile errors in the Maven build. Could we just introduce the dependency through Maven rather than Tycho?

I am not sure if that is possible because Kotlin is a runtime dependency and Eclipse only accepts plugins in its runtime. We could try to pull the dependency via maven central and then put it on the plugin's classpath but I have the feeling that we already tried that in the past and it was problematic. One thing I am certain of is that it will complicate the build process in the Eclipse IDE because Eclipse does not like to mix maven and eclipse dependencies in the same project.
I hope the restructuring in #1276 will resolve the barriers in the future. However, the structure described there is not yet possible. I have to change the build process for the diagrams and the LDS first, and also have to find a workaround to get it working in an Eclipse plugin without problems on the classpath. It is definitely on my short-term Todo list but I currently do not have the time to tackle this.

@lhstrh
Copy link
Member Author

lhstrh commented Sep 21, 2022

OK, thanks for looking into this, @a-sr. It sounds like there is no way to properly support Epoch on macOS then, because code signing won't work if the Kotlin plugin is included, and building Epoch won't work without the Kotlin plugin.

@lhstrh lhstrh reopened this Sep 30, 2022
@lhstrh
Copy link
Member Author

lhstrh commented Oct 1, 2022

Confirmed that this doesn't impair the code generators that are written in Kotlin.

@lhstrh lhstrh merged commit c4589c8 into master Oct 1, 2022
@lhstrh lhstrh deleted the rm-unsigned-deps branch October 1, 2022 04:05
@lhstrh lhstrh added the bugfix label Jan 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants