Infrastructure for AST transformations and factored out delay transformation #1508
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cmnrd
requested review from
petervdonovan,
lhstrh,
oowekyala and
marcusrossel
7 tasks
oowekyala
reviewed
Dec 19, 2022
org.lflang/src/org/lflang/generator/cpp/CppDelayBodyGenerator.kt
Outdated
Show resolved
Hide resolved
This was referenced Dec 19, 2022
marcusrossel
approved these changes
Dec 19, 2022
lhstrh
approved these changes
Dec 19, 2022
| /** | ||
| * Apply the AST transformation to all given reactors. | ||
| */ | ||
| void applyTransformation(List<Reactor> reactors); |
There was a problem hiding this comment.
I would change this to take in the entire resource so that the interface is more general.
There was a problem hiding this comment.
Yes, my first intuition was also to pass the model and/or the resource. However, it appears that there is some intelligence built into generating this list of reactors (this is handled by the instance graph). We would need to duplicate that code or refactor it to make it reusable, but I wanted to avoid spending too much time on this. Also I am not sure which information other than transformations we would need. I suggest to revisit this as part of fixing #1510
org.lflang/src/org/lflang/generator/cpp/CppDelayBodyGenerator.kt
Outdated
Show resolved
Hide resolved
Co-authored-by: Marten Lohstroh <[email protected]>
13 tasks
lhstrh
added
refactoring
lhstrh
changed the title
petervdonovan
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The main motivation of this PR is to apply the after delay transformation only optionally when needed by the target.
Currently, the after delay transformation is handled in between some other important passes in
GeneratorBaseand cannot easily be moved such that it can be called directly by our code generators before or after invokingGeneratorBase. Therefore, this PR introduces aTransformationinterface which allows the target generators to register transformations which are then automatically applied.This PR implements the
AfterDelayTransformationand factors out the target specific code into a new interfaceDelayBodyGeneratorwhich the targets need to provide.