Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up attributes in fed-gen #1552

Merged
merged 7 commits into from
Jan 17, 2023
Merged

Clean up attributes in fed-gen #1552

merged 7 commits into from
Jan 17, 2023

Conversation

cmnrd
Copy link
Collaborator

@cmnrd cmnrd commented Jan 17, 2023

#1221 introduces several new attributes. Some of them are overly general (@languange) and others are redundant. This PR cleans up the newly introduced attributes.

This PR also includes some additional small cleanups including resetting .idea/codeStyles/Project.xml to the version from master.

@lhstrh
Copy link
Member

lhstrh commented Jan 17, 2023

I think the changes you made here make sense. That said, I think that it might be cleaner to just reserve a single @generated attribute for code-gen-related stuff and just have key-value pairs in it. I think that's neater than a _ prefix, which looks ugly (let's not use underscores in these at all). We can change this later because this only concerns cosmetics and isn't user-facing.

@lhstrh lhstrh merged commit ddeac11 into fed-gen Jan 17, 2023
@lhstrh lhstrh deleted the fed-gen-attributes branch January 17, 2023 21:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants