Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix failing building of tracing tools #1589

Merged
merged 11 commits into from
Feb 15, 2023
Merged

Fix failing building of tracing tools #1589

merged 11 commits into from
Feb 15, 2023

Conversation

erlingrj
Copy link
Collaborator

@erlingrj erlingrj commented Feb 15, 2023 •
edited
Loading

  1. Add building of the tracing tools to the CI (However this wont run until it is in master)
  2. Pass LF_UNTHREADED=1 to the building of the tracing tools. Using LF_THREADED=1 does not work unless we add some threading specific files to the build..

@erlingrj erlingrj marked this pull request as draft February 15, 2023 16:26
@erlingrj erlingrj marked this pull request as ready for review February 15, 2023 17:20
edwardalee
edwardalee approved these changes Feb 15, 2023
View reviewed changes
Copy link
Collaborator

@edwardalee edwardalee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@lhstrh
Copy link
Member

lhstrh commented Feb 15, 2023

Thanks, @erlingrj! I took the liberty to decouple the trace tool build test from the c-tests because I think it is better that way...

@lhstrh lhstrh added tracing Related to the tracing functionality of various targets. bugfix labels Feb 15, 2023
@lhstrh lhstrh merged commit a8486ac into master Feb 15, 2023
@hokeun hokeun deleted the fix-tracing-util branch November 8, 2023 17:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lhstrh lhstrh lhstrh approved these changes

@edwardalee edwardalee edwardalee approved these changes

Assignees
No one assigned
Labels
bugfix tracing Related to the tracing functionality of various targets.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@erlingrj @lhstrh @edwardalee