Set external runtime path #1633
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When we make changes to reactor-ts and accompanying changes in lingua-franca we cannot point to the version of reactor-ts that is published on NPM. We need to clone a specific ref and point to it. Locally, pointing to the correct runtime version fixes the problem that I observed in #1607. If this change to the yaml file is correct then this should make that PR mergeable.
lhstrh
reviewed
Mar 10, 2023
| .collect(Collectors.toUnmodifiableSet()); | ||
|
|
||
| Properties props = new Properties(); | ||
|
|
||
| for (OptionSpec option : spec.options()) { | ||
| String optionName = option.longestName(); | ||
| if (optionName.startsWith("--")) optionName = optionName.substring(2); |
There was a problem hiding this comment.
Suggested change
| if (optionName.startsWith("--")) optionName = optionName.substring(2); |
| @@ -261,27 +261,26 @@ protected Properties filterPassOnProps() { | |||
| BuildParm.SCHEDULER, | |||
| BuildParm.THREADING, | |||
| BuildParm.WORKERS) | |||
| .map(param -> param.getKey()) | |||
| .map(BuildParm::getKey) | |||
| .collect(Collectors.toUnmodifiableSet()); | |||
|
|
|||
| Properties props = new Properties(); | |||
|
|
|||
| for (OptionSpec option : spec.options()) { | |||
| String optionName = option.longestName(); | |||
There was a problem hiding this comment.
Suggested change
| String optionName = option.longestName(); | |
| String optionName = option.descriptionKey(); |
There was a problem hiding this comment.
I think I commented this earlier, but I couldn't see my comment anymore. This issue was fixed on master #1631 in a different way.
Co-authored-by: Marten Lohstroh <[email protected]>
petervdonovan
commented
Mar 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When we make changes to reactor-ts and accompanying changes in
lingua-franca we cannot point to the version of reactor-ts that is
published on NPM. We need to clone a specific ref and point to it.
Locally, pointing to the correct runtime version fixes the problem that
I observed in #1607. If this change to the yaml file is correct then
this should make that PR mergeable.
This PR also fixes a bug in the way we pass CLI args because this bug was inhibiting my ability to debug #1607. I decided to fix the bug rather than working around it