Bugfixes in handling of files target property
#1725
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resources identified by some string and to be looked up relative to a source file, a package, or on the class path, could be files or directories, and there is no way to tell what it is until a matching entry has been found. Therefore, it is most convenient if we provide a lookup mechanism that will work with strings, regardless of whether they point to files or directories. PR #1700 that was merged recently, attempted to furnish this API, but introduces some bugs. This PR fixes those bugs and tries to make the public APIs a bit more friendly improves the documentation.
One issue is that file interactions are different depending on whether tests are executed through JUnit or using
lfc. We need to add a few unit tests to get full coverage ofFileUtil, but we should merge this in first because it address the current CI failure onmaster.