Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix to allow CLI args to be passed to federates #1798

Merged
merged 3 commits into from
May 30, 2023

Conversation

petervdonovan
Copy link
Collaborator

When debug mode is set using a CLI argument, it does not seem to be passed on to federates generated in fed-gen. This amends that.

Copy link
Member

@lhstrh lhstrh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch! Thanks, @petervdonovan.

@lhstrh lhstrh enabled auto-merge May 30, 2023 19:51
Copy link
Collaborator

@edwardalee edwardalee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, this could explain it. I guess this has been happing since fedgen.

@lhstrh lhstrh merged commit c5f4c9d into master May 30, 2023
@cmnrd cmnrd deleted the pass-cli-arg-to-federates branch May 31, 2023 07:31
@lhstrh lhstrh changed the title Pass CLI args to federates Fix to allow CLI args to be passed to federates Aug 28, 2023
@lhstrh lhstrh added the bugfix label Aug 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants