Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generate default values for the user-configurable CMake flags #2036

Merged
merged 5 commits into from
Oct 9, 2023

Conversation

erlingrj
Copy link
Collaborator

@erlingrj erlingrj commented Oct 3, 2023

This adds default values to the CMake flags which currently is passed over the command line when invoking cmake. This removes the need for:

  1. Generating a .vscode/settings.json file to open and build generated sources in VScode.
  2. The need for lfc to invoke cmake with all the flags
  3. The need to generate CompileDefinitons.txt with the default values

Closing #1677

@erlingrj erlingrj linked an issue Oct 3, 2023 that may be closed by this pull request
@erlingrj
Copy link
Collaborator Author

erlingrj commented Oct 3, 2023

I am asking for your feedback here, @petervdonovan, since I believe you made the CMake integration and you might have some arguments for why we should not put the default flags in the generates CMakeLists.txt and instead pass them on the command line.

@petervdonovan
Copy link
Collaborator

I am in favor of this! IIRC we have discussed this as a group multiple times and collectively agreed that this is the right choice.

@erlingrj erlingrj requested a review from lhstrh October 4, 2023 18:33
Copy link
Member

@lhstrh lhstrh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks nice!

@erlingrj erlingrj added this pull request to the merge queue Oct 9, 2023
Merged via the queue into master with commit 529a217 Oct 9, 2023
41 checks passed
@erlingrj erlingrj deleted the default-cmake-flags-in-c branch October 9, 2023 18:48
@lhstrh lhstrh added the enhancement Enhancement of existing feature label Jan 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Enhancement of existing feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Making the src-gen folder more stand-alone
3 participants