New --no-source-mapping switch to disable line directives
#2092
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lhstrh
changed the title
--no-source-mapping switch to disable line directives--no-source-mapping switch to disable line directives
lhstrh
commented
Nov 12, 2023
core/src/main/java/org/lflang/target/property/NoSourceMappingProperty.java
Outdated
Show resolved
Hide resolved
lhstrh
force-pushed
the
no-source-mapping
branch
from
ff44c0e
to
0b491f5
Compare
petervdonovan
approved these changes
Nov 13, 2023
There was a problem hiding this comment.
Yep, looks good, let's merge.
I'll admit I was initially surprised to see such a big diff, but this approach is probably safer than a global variable and can't really go wrong as long as the suppress parameter comes from the right source, which should be an easy guideline to follow. An alternative would have been to strip out all the #line directives at the very end, but that wouldn't necessarily be better.
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2093.