Fix for #2087 #2147
Merged
Fix for #2087 #2147
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
a-sr
force-pushed
the
fix-duplicate-attrparm
branch
from
a902482
to
d4bab05
Compare
lhstrh
requested changes
Jan 11, 2024
lhstrh
approved these changes
Jan 24, 2024
lhstrh
force-pushed
the
fix-duplicate-attrparm
branch
from
678c6bb
to
df85bbf
Compare
|
Thank you for adding the test. I was quite busy the last days. |
|
No worries. I realized, however, that we still have some work to do in terms of validation, but that can be done later (see #2162). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes incorrect scope for detection of duplicate IDs in attribute parameters. Now only duplicate parameter IDs in the same attribute raise and error.
Closes #2087.