Use login shell so ~/.bash_profile is sourced #2169
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I don't think this two-byte change really requires a review, so rather than waste people's time, I'm putting this in the merge queue. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In resurrecting the MQTT examples in the playground, I realized that the shell script that we generate to launch a federate does not source
~/.bash_profile, which makes it much more difficult to use external libraries with federated programs. The federates can be launched manually, but the shell script to launch them will not work. In the case of MQTT, it needs to find the Paho MQTT dynamically linked libraries, and without this change, there is no way to tell the script where to find them.