Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improvements in decentralized coordination #2394

Merged
merged 27 commits into from
Aug 8, 2024
Merged

Improvements in decentralized coordination #2394

merged 27 commits into from
Aug 8, 2024

Conversation

edwardalee
Copy link
Collaborator

@edwardalee edwardalee commented Aug 3, 2024 •
edited
Loading

This PR is a companion to lf-lang/reactor-c#476.
Changes include:

  • Allowing use of STA instead of STP_offset and STAA instead of STP.
  • Allowing code blocks for setting the STA in the C target (was already allowed for Python).
  • Add tests and fix one Python test to not hang on shutdown.

@edwardalee edwardalee changed the title Tests for dataflow style of decentralized coordination Improvements in decentralized coordination Aug 5, 2024
@edwardalee edwardalee mentioned this pull request Aug 5, 2024
Merged
@Depetrol Depetrol mentioned this pull request Aug 6, 2024
Closed
@edwardalee edwardalee marked this pull request as ready for review August 6, 2024 09:07
lhstrh
lhstrh reviewed Aug 7, 2024
View reviewed changes
Copy link
Member

@lhstrh lhstrh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These changes look like good improvements. The usability difficulties and terminology issues remain, but those should be addressed in a separate PR... I do think it's a good idea to prioritize syntax improvements.

core/src/main/java/org/lflang/LinguaFranca.xtext Show resolved Hide resolved
core/src/main/java/org/lflang/validation/LFValidator.java Show resolved Hide resolved
@edwardalee edwardalee added this pull request to the merge queue Aug 8, 2024
Merged via the queue into master with commit 058e1ec Aug 8, 2024
26 checks passed
@edwardalee edwardalee deleted the dataflow branch August 8, 2024 21:00
@lhstrh lhstrh removed the testing label Sep 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Depetrol Depetrol Depetrol approved these changes

@lhstrh lhstrh lhstrh approved these changes

Assignees
No one assigned
Labels
bugfix
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@edwardalee @lhstrh @Depetrol