-
Notifications
You must be signed in to change notification settings - Fork 63
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Properly implement scoping rules in the generated C++ code #375
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
... and generate inner constructor definition
This reverts commit 26d2699.
cmnrd
changed the title
WIP: Properly implement scoping rules in the generated C++ code
Properly implement scoping rules in the generated C++ code
Jun 30, 2021
@lhstrh This is ready for merging now. |
lhstrh
approved these changes
Jul 6, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Excellent! Glad you managed to address this!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR prevents target code from accessing timers, ports, or actions that have not been declared as triggers, sources, or effects of the reaction in LF code. Accessing undeclared triggers, sources, or effects results in compiler errors. Also, scheduling an action that is only referenced as a trigger or source (but not an effect) results in a compile error (this is related to #339). There is actually no trivial way for the C++ programmer to circumvent this mechanism. Thus, this change should significantly improve the reliability of reactors written in C++.
This is based on thekotlin-cpp-generator
branch and requires #356 and #345 to be merged first. I will mark this PR as draft until the other two PRs are merged.Closes #66.
Closes lf-lang/reactor-cpp#1