-
-
Notifications
You must be signed in to change notification settings - Fork 63
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
generate docker compose files for federated execution #754
Conversation
4d5efd2
to
9af688c
Compare
0b8263d
to
38ff61e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this looks great!
In the interest of a more modular design, it would be great if the docker-related functions were in a separate CDockerGenerator.java
class (following the naming convention of the Cpp and TS generators).
@housengw could you please provide a bit more explanation on what this PR is meant to achieve? |
This PR is meant to autogenerate |
make sure tests pass after adding code generation for docker compose.
This branch is branched from #750
Also, I will try to refactor CGenerator.doGenerate() since it currently has about 500 lines.