Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

generate docker compose files for federated execution #754

Merged
merged 8 commits into from
Dec 8, 2021

Conversation

housengw
Copy link
Contributor

@housengw housengw commented Nov 16, 2021

make sure tests pass after adding code generation for docker compose.
This branch is branched from #750

Also, I will try to refactor CGenerator.doGenerate() since it currently has about 500 lines.

@Soroosh129 Soroosh129 changed the base branch from master to docker-test November 16, 2021 23:46
@housengw housengw changed the title Test generate docker compose generate docker compose Nov 18, 2021
@housengw housengw changed the title generate docker compose generate docker compose and refactor doGenerate Nov 18, 2021
@housengw housengw marked this pull request as ready for review November 27, 2021 07:01
@housengw housengw changed the base branch from docker-test to master November 30, 2021 17:25
@housengw housengw changed the base branch from master to docker-test November 30, 2021 17:25
@housengw housengw changed the title generate docker compose and refactor doGenerate generate docker compose files for federated execution Dec 1, 2021
Copy link
Contributor

@Soroosh129 Soroosh129 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this looks great!

In the interest of a more modular design, it would be great if the docker-related functions were in a separate CDockerGenerator.java class (following the naming convention of the Cpp and TS generators).

Base automatically changed from docker-test to master December 3, 2021 06:03
@lhstrh
Copy link
Member

lhstrh commented Dec 3, 2021

@housengw could you please provide a bit more explanation on what this PR is meant to achieve?

@housengw
Copy link
Contributor Author

housengw commented Dec 3, 2021

This PR is meant to autogenerate docker-compose.yml files upon calling lfc on containerized federated lf programs. The purpose of docker-compose.yml files is to help ease the deployment of multiple docker containers. The user could do docker compose up in the directory where docker-compose.yml is located and the instruction in the yaml tells docker how to build and run the containers. Without the yaml, the user will have to build and run the an image for each federate manually.

@housengw housengw requested a review from lhstrh December 4, 2021 18:13
@housengw housengw merged commit d705e8f into master Dec 8, 2021
@housengw housengw deleted the generate-docker-compose branch December 8, 2021 16:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants