Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test Maven build in CI #866

Merged
merged 7 commits into from
Jan 20, 2022
Merged

Test Maven build in CI #866

merged 7 commits into from
Jan 20, 2022

Conversation

lhstrh
Copy link
Member

@lhstrh lhstrh commented Jan 19, 2022

This PR adds testing of the Maven build to our CI workflow. An initial run of the new workflow that the build had already broken. Fixes are included. Specifically:

Problem 1:

Error:  /home/runner/work/lingua-franca/lingua-franca/org.lflang/src/org/lflang/generator/rust/RustTypes.kt:[58,37] Super calls to Java default methods are prohibited in JVM target 1.6. Recompile with '-jvm-target 1.8'

Solution 1: bump Kotlin from 1.4.10 to 1.6.10

Problem 2:

Error:  /home/runner/work/lingua-franca/lingua-franca/org.lflang.diagram/src/org/lflang/diagram/lsp/Progress.java:[104] 
Error:  	client.notifyProgress(new ProgressParams(Either.forRight(token), Either.forLeft(notification)));
Error:  	                      ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
Error:  The constructor ProgressParams(Either.forRight(token), Either.forLeft(notification)) is undefined
Error:  1 problem (1 error)

Solution 2: revert ee19274 (already done in master)

Fixes #861

@lhstrh lhstrh merged commit e9daa40 into master Jan 20, 2022
@cmnrd
Copy link
Collaborator

cmnrd commented Jan 20, 2022

This addresses the Maven part of #575, right? I wonder if we should close this issues, as there seems to be no solution for testing the eclipse build.

@cmnrd cmnrd deleted the ci branch January 20, 2022 15:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add task to CI that checks whether build artifacts are successfully created
2 participants