Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Python scalability banks #873

Merged
merged 70 commits into from
Jan 29, 2022
Merged

Python scalability banks #873

merged 70 commits into from
Jan 29, 2022

Conversation

Soroosh129
Copy link
Contributor

@Soroosh129 Soroosh129 commented Jan 22, 2022 •
edited
Loading

This PR is a supplement to #843. This updates the PythonGenerator to add the following:

  • use of the new and updated banks support introduced in Scalability banks #843
    • This has a user-facing side effect that bank index is now also a proper parameter in the Python target that can be passed down the hierarchy (added to RELEASES.md)
  • tests introduced in Scalability banks #843 for the C target ported to Python
  • support for sending to and receiving from contained banks (necessary for the added tests to pass)
  • fixes for formatting issues in PythonGenerator.xtend (to make it easier to port to Java)
  • changes introduced in [Python] add federated send class test #826 (already reviewed)
  • updates to use the new CodeBuilder introduced in Code emitter #892 (needed to fix merge conflicts with master)

Most of the changes are due to the format fixes, and are purely superficial.

housengw and others added 30 commits January 4, 2022 18:15
@housengw
add federated send class test
239e875
@housengw
add more send class tests
a294016
@housengw
add no react test
24e8a2b
@Soroosh129
Updated the Python generator to use the new bank index scheme
c63aceb
@Soroosh129
Added the nested banks test
90ca83d
@Soroosh129
Comments only
85ad7ae
@Soroosh129
Added PyUtil
12b9192
@Soroosh129
Updated source code format of the PythonGenerator
ca47625
@Soroosh129
Fixed syntax error
8943031
@Soroosh129
First step toward supporting sending/receiving to contained banks (C …
9c8b937 
…side)
@Soroosh129
Interim commit to fix the Python side
22cb830
@Soroosh129
Slightly adjusted example
9b2c4a6
@Soroosh129
Skeleton of the intersection demo in ROS
94142e1
@Soroosh129
Revert "Skeleton of the intersection demo in ROS"
2495ab5 
This reverts commit 94142e1.
@Soroosh129
Revert "Slightly adjusted example"
0cdba6d 
This reverts commit 9b2c4a6.
@lhstrh @Soroosh129
Ported LinguaFrancaScopingTest to Java
67bb9a5
@lhstrh @Soroosh129
Ported one more class and added a utility.
413e8e3
@lhstrh @Soroosh129
Respond to comments from @oowekyala
1ef5a51
@lhstrh @oowekyala @Soroosh129
Update org.lflang.tests/src/org/lflang/tests/compiler/LinguaFrancaAST…
943cae0 
…UtilsTest.java

Co-authored-by: Clément Fournier <[email protected]>
@housengw @Soroosh129
cleanup scripts
0d7363a
@housengw @Soroosh129
improve log readability
06610a9
@housengw @Soroosh129
update dev docs
0e8f6b5
@housengw @Soroosh129
nonfunctional double unlock demo
99c939b
@housengw @Soroosh129
refactor Key fob demo
9433261
@housengw @Soroosh129
rename lock_status to lock_state
b73da8c
@housengw @Soroosh129
functional double unlock demo without autolock
f3124e2
@housengw @Soroosh129
refactor messages
8852721
@housengw @Soroosh129
resolve conflicts
446dcc0
@housengw @Soroosh129
add autolock feature
9744d3d
@housengw @Soroosh129
added intermediate logical action
3716c5c
@lhstrh
Copy link
Member

lhstrh commented Jan 25, 2022

Looks like we should change the base of this to master?

@Soroosh129 Soroosh129 changed the base branch from scalability-banks to master January 25, 2022 23:16
@Soroosh129 Soroosh129 marked this pull request as ready for review January 27, 2022 07:30
lhstrh
lhstrh approved these changes Jan 28, 2022
View reviewed changes
Copy link
Member

@lhstrh lhstrh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great. No comments from my side.

@lhstrh lhstrh mentioned this pull request Jan 29, 2022
Merged
@lhstrh lhstrh merged commit 5e3d184 into master Jan 29, 2022
@lhstrh lhstrh deleted the python-scalability-banks branch January 29, 2022 00:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@housengw housengw housengw left review comments

@lhstrh lhstrh lhstrh approved these changes

@edwardalee edwardalee Awaiting requested review from edwardalee

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Soroosh129 @lhstrh @housengw @petervdonovan