Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Xtend to java tests #877

Merged
merged 12 commits into from
Jan 25, 2022
Merged

Xtend to java tests #877

merged 12 commits into from
Jan 25, 2022

Conversation

housengw
Copy link
Contributor

@housengw housengw commented Jan 22, 2022

See #838

  • DependencyAnalysisTest
  • ParsingTest
  • ValidationTest

@housengw housengw marked this pull request as draft January 22, 2022 23:13
@lhstrh
Copy link
Member

lhstrh commented Jan 23, 2022

Please keep an eye on #838 to avoid doing double work... There are other PRs open right now that overlap with this one...

@housengw housengw changed the base branch from master to xtend-to-java January 23, 2022 06:12
@housengw housengw changed the base branch from xtend-to-java to master January 23, 2022 06:13
@housengw
Copy link
Contributor Author

housengw commented Jan 23, 2022

Thanks for the reminder. I double checked and only did the files that were not ported in #844

@housengw housengw marked this pull request as ready for review January 24, 2022 19:17
Copy link
Member

@lhstrh lhstrh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Left a comment.

Copy link
Member

@lhstrh lhstrh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Thanks for porting these!

@lhstrh lhstrh merged commit fa41364 into master Jan 25, 2022
@lhstrh lhstrh deleted the xtend-to-java-tests branch January 25, 2022 22:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants