Scale back LSP tests #944
Merged
Scale back LSP tests #944
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
petervdonovan
force-pushed
the
scale-back-lsp-tests
branch
5 times, most recently
from
2336607
to
bde16fb
Compare
|
OK, this PR has changed the tests so that the random number generator's state is different, and now it is blocked by test failures that cannot be reproduced locally. PyLint EDIT. Problem "fixed" by waiting for months and then rebasing. Probably this is one of the worst ways to fix a persistent problem in our tests, but it seems to be working... |
Since those tests were written, this functionality has been used in the runtime tests. If it breaks, the runtime tests will fail.
This failure cannot be reproduced locally, even with the same PyLint version and the same random seed.
This is a response to failures on remote that could not be reproduced locally. It is unclear what causes it, but if it is nondeterminism in order of test execution, then the previous way of fixing the seed was no good. With this approach, the seed will be different for every test run, but at least the seed will be reported so that failures can be debugged.
petervdonovan
force-pushed
the
scale-back-lsp-tests
branch
2 times, most recently
from
ec582f3
to
a2bd658
Compare
lhstrh
reviewed
May 17, 2022
Definitely not -- I missed that while I was rebasing. |
lhstrh
approved these changes
May 17, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This scales back LSP tests because they have been taking a little more computational resources on GitHub Actions than is ideal. Additionally, the "build and run" tests are now redundant.