Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Port GeneratorBase.xtend to Java #974

Merged
merged 7 commits into from
Mar 2, 2022
Merged

Port GeneratorBase.xtend to Java #974

merged 7 commits into from
Mar 2, 2022

Conversation

housengw
Copy link
Contributor

See #838

@housengw housengw requested a review from lhstrh March 1, 2022 20:45
lhstrh
lhstrh approved these changes Mar 2, 2022
View reviewed changes
Copy link
Member

@lhstrh lhstrh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks like a valid translation to me!

@housengw housengw force-pushed the xtend-to-java-generator-base branch from 7d39953 to cbd5d12 Compare March 2, 2022 01:11
@housengw housengw merged commit 84c9c3d into master Mar 2, 2022
@housengw housengw deleted the xtend-to-java-generator-base branch March 10, 2022 23:49
@lhstrh lhstrh mentioned this pull request Mar 17, 2022
Closed
@lhstrh lhstrh added the refactoring Code quality enhancement label Mar 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lhstrh lhstrh lhstrh approved these changes

Assignees
No one assigned
Labels
refactoring Code quality enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@housengw @lhstrh