Improved CMake configuration #137
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Btw, @petervdonovan can you immediately see why the CI is not running on my PRs? |
|
No, I'm not sure why not. I think that sometimes one has to merge master into the branch in order to trigger CI. |
petervdonovan
approved these changes
Jan 7, 2023
|
OK. Just have to fix the CI. @lhstrh. There is something wrong with the CI see here: https://github.com/lf-lang/reactor-c/actions/runs/3864134424/workflow
Do you understand anything of this? |
|
Oh, I get it now. Dongha just forgot to change from Actually, I'll just do that right now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mainly changing how reactor-c corelib is built. Originally it used
add_subdirectoryto add platform, modal, threaded and utils sources. This is a bit hacky since it creates new node and compile definitions and sources can not easily be added to the parent node. Now I useincludeinstead. Needed some additional changes for this to work.