Handle messages arriving during initial STA wait #316
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some errors have appeared in master that are not caught. For example, the federated STPParameter.lf test case prints the following error message:
In fact, the "Received 1" message is supposed to occur before the "Timer ticked" message.
I assume that this has been changed to a non-fatal error to prevent flaky test failures, but in this case, it is masking a real test failure.
This PR pulls events off the event queue before advancing to the start time so that messages received during the initial STA wait are properly handled.
However, it turns out there are more problems. The federated test DecentralizedP2PComm succeeds but prints out the following error messages:
So there are more problems...