Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add an option for specifying the time interval of showing messages to the tracing visualizer #320

Merged
merged 9 commits into from
Jan 12, 2024
Merged

Add an option for specifying the time interval of showing messages to the tracing visualizer #320

merged 9 commits into from
Jan 12, 2024

Conversation

byeonggiljun
Copy link
Collaborator

The tracing visualization program fedsd takes command line arguments of the start and end time to let users be able
to specify the target time interval of the visualized trace.

@byeonggiljun byeonggiljun changed the title Add an option for specifying the time interval of showing messages to the tracing visualization program Add an option for specifying the time interval of showing messages to the tracing visualizer Dec 19, 2023
@byeonggiljun byeonggiljun added the enhancement Enhancement of existing feature label Dec 19, 2023
@byeonggiljun byeonggiljun marked this pull request as draft January 11, 2024 00:18
@byeonggiljun byeonggiljun marked this pull request as ready for review January 11, 2024 21:36
hokeun
hokeun reviewed Jan 11, 2024
View reviewed changes
Copy link
Member

@hokeun hokeun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks nice! Just left minor comments.

util/tracing/visualization/fedsd.py Outdated Show resolved Hide resolved
util/tracing/visualization/fedsd.py Outdated Show resolved Hide resolved
util/tracing/trace_to_csv.c Outdated Show resolved Hide resolved
util/tracing/trace_to_csv.c Outdated Show resolved Hide resolved
hokeun
hokeun approved these changes Jan 11, 2024
View reviewed changes
Copy link
Member

@hokeun hokeun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@byeonggiljun byeonggiljun merged commit a985205 into main Jan 12, 2024
28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hokeun hokeun hokeun approved these changes

@lhstrh lhstrh Awaiting requested review from lhstrh

Assignees
No one assigned
Labels
enhancement Enhancement of existing feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@byeonggiljun @hokeun