No use of C11 threads on Windows #364
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
petervdonovan
force-pushed
the
windows-c11
branch
from
10a2d0c
to
3e56e0b
Compare
If you are using a Windows C toolchain (MSVC) then you should not expect it to keep up with the standard.
petervdonovan
force-pushed
the
windows-c11
branch
from
3e56e0b
to
ab54a2e
Compare
The Arduino and Zephyr tests should be running
lhstrh
reviewed
Feb 23, 2024
|
OK so now this PR is blocked by the fact that the PR that we just merged is rejected by AppleClang. I guess I jumped the gun in marking ready for review. |
Clang it! |
petervdonovan
force-pushed
the
windows-c11
branch
from
a004160
to
7b3ce0d
Compare
lhstrh
approved these changes
Feb 23, 2024
lhstrh
changed the title
lhstrh
changed the title
petervdonovan
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This branch is an attempt to address the failing Windows tests on
main.