Fix tagged message length from int32_t to uint32_t
#368
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
edwardalee
approved these changes
Feb 27, 2024
There was a problem hiding this comment.
LGTM! Perhaps the comment in net_common.h documentation for MSG_TYPE_TAGGED_MESSAGE should change as follows: It currently reads:
* The four bytes after that will be the length of the message.
Perhaps it should read:
* The four bytes after that will be the length of the message (as an unsigned 32-bit int).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The tagged message sends a message length of int32_t. The length should not be negative, so changing it to uint32_t.
It also makes the maximum size of the tagged message from 2GB to 4GB.
By the way, the typescript target already writes in unsigned int 32 type.