Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Workers #50

Merged
merged 11 commits into from
Mar 10, 2022
Merged

Workers #50

merged 11 commits into from
Mar 10, 2022

Conversation

Soroosh129
Copy link
Contributor

@Soroosh129 Soroosh129 requested a review from lhstrh March 9, 2022 19:45
edwardalee
edwardalee approved these changes Mar 9, 2022
View reviewed changes
Copy link
Contributor

@edwardalee edwardalee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks like a really good solution to me.

core/threaded/reactor_threaded.c Outdated Show resolved Hide resolved
lhstrh
lhstrh approved these changes Mar 9, 2022
View reviewed changes
Copy link
Member

@lhstrh lhstrh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Thanks for turning this around so quickly!

core/platform.h Outdated Show resolved Hide resolved
core/platform/lf_unix_syscall_support.c Outdated Show resolved Hide resolved
core/threaded/reactor_threaded.c Outdated Show resolved Hide resolved
lhstrh
lhstrh approved these changes Mar 9, 2022
View reviewed changes
Copy link
Member

@lhstrh lhstrh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀🚀🚀

core/platform/lf_unix_syscall_support.c Outdated Show resolved Hide resolved
@lhstrh lhstrh merged commit 0863fe1 into main Mar 10, 2022
@lhstrh lhstrh deleted the workers branch March 10, 2022 01:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lhstrh lhstrh lhstrh approved these changes

@edwardalee edwardalee edwardalee approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Soroosh129 @edwardalee @lhstrh