Fix to allow ports to have both triggers and further bindings #16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In case of nested reactors, the outer reactor might have a reaction triggered by the port, but also a connection to an input of the nested reactor.
cmnrd
force-pushed
the
fix-nested-reactions
branch
from
33fb712
to
033efb2
Compare
cmnrd
added a commit
to lf-lang/lingua-franca
that referenced
this pull request
Jul 8, 2022
The reactor-cpp runtime did not correctly handle multiple reactions in different nested reactors that are triggered by the same port upstream port. This change pulls in a fix in reactor-cpp and adds an LF test. Related reactor-cpp PR: lf-lang/reactor-cpp#16
lhstrh
changed the title
lhstrh
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In case of nested reactors, the outer reactor might have a reaction triggered by the port, but also a connection to an input of the nested reactor.