Fixed bug that arises when enabling tracing in programs with enclaves. #55
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
julianrobledom
commented
Mar 20, 2024
julianrobledom
commented
- Action tracing takes the action container as argument, but in a program with enclaves some of the actions might not have a container, which leads to segmentation fault.
- The bug was fixed by giving the environment name as parameter instead of the container name, for the actions without a container.
- Notice that the bug only arises if a tracing session was started with the ./tracing/start_tracing.sh script, before running the lf program.
- Action tracing takes the action container as argument, but in a program with enclaves some of the actions might not have a container, which leads to segmentation fault. - The bug was fixed by giving the environment name as parameter instead of the container name, for the actions without a container. - Notice that the bug only arises if a tracing session was started with the ./tracing/start_tracing.sh script, before running the lf program.
|
The bug is related to lf-lang/lingua-franca#2119 (comment) |
cmnrd
approved these changes
Mar 21, 2024
cmnrd
added a commit
to lf-lang/lingua-franca
that referenced
this pull request
Mar 21, 2024
This pulls in lf-lang/reactor-cpp#55 Fixes #2119
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.