[run-tests][fix][tests] Fix resource leak in tests. Call cleanup before setup #88
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lhotari
changed the title
4 tasks
- when setup is called explicitly, cleanup should be issued before it
- remove unnecessary "resetConfig" method calls
- resetConfig gets called as part of internalCleanup
- when resetConfig is in cleanup, it's possible to override config before calling setup
- this allows using setup & cleanup methods instead of using
error prone internalSetup and internalCleanup methods which might leave something behind
lhotari
force-pushed
the
lh-fix-resourceleak-in-tests
branch
from
13bdf51 to
486c670
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
upstream PR apache#17743