Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for network visualiser when connected to shared instance #14

Merged
merged 1 commit into from
Sep 25, 2024

Conversation

markqvist
Copy link
Contributor

This PR adds support for parent/child interface visualization when connected to a shared RNS instance, and removes dependency on manually getting certain interface-specific characteristics such as hash and name, since these were added natively in RNS 42319a092db0d593e35f07478d1eece907f3bb88.

Also fixes a bug where the network visualizer would fail if a probe responder was active on the transport node.

@markqvist
Copy link
Contributor Author

markqvist commented Sep 24, 2024

Tested on one of my well-connected testnet hubs with ~120 interfaces. Much spring, but works nicely!

meshchat_netvis

@liamcottle
Copy link
Owner

Holy moly! That's a fair few interfaces!

Thanks for the PR and for adding those extra infos natively :)

I'll get this merged in once RNS has a release available to pull in.

@liamcottle liamcottle merged commit 417c9be into liamcottle:master Sep 25, 2024
@markqvist
Copy link
Contributor Author

Thanks for the merge! It would be quite nice if you can also add custom display names to the network visualiser, so that if a custom name is set on a conversation, it will use that in the visualiser too. I tried messing around with it a bit today, but I am completely unfamiliar with Vue, and figured I'd likely just break something, or implement it wrong, so I'd rather leave it to you :) Just a humble request, but man would it be nice :)

@liamcottle
Copy link
Owner

Done :) Added in 000b515 and 1c1d820

@markqvist
Copy link
Contributor Author

AWESOME!

@faragher
Copy link

Question: Does this generalize out to being able to look at "parent_interface_name/hash" on any shared Reticulum instance for identifying which interface an announce came in on?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants