Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initial Camera Port #53

Merged
merged 14 commits into from
Mar 21, 2023
Merged

Initial Camera Port #53

merged 14 commits into from
Mar 21, 2023

Conversation

olijeffers0n
Copy link
Contributor

@olijeffers0n olijeffers0n commented Mar 18, 2023

Closes #52

This adds the ability to control and render cameras from RustPlus.js

WIP - Docs to come. As a predominantly Java & Python Developer, let me know of any code style issues. The rendering is grim, however this is just something that must be done.

  • Review Protobuf Definitions for some type changes.
  • Reword Comments on the input types.
  • DeObfuscate decoding logic where possible.

@liamcottle
Copy link
Owner

Nice work,

I'll do a proper review of the code, make a few changes and get it merged in. Will likely be a couple of days.

Thanks!

@olijeffers0n olijeffers0n marked this pull request as ready for review March 20, 2023 12:18
@olijeffers0n
Copy link
Contributor Author

Sounds good Liam. I have added an example for the usage and added RateLimit info. The Rendering is not that easy to follow but I am considering it as a "It works, don't question it" type of code block. If you really want I am happy to go through and try and put some meaningful variable names in, but I don't think that really adds much.

@liamcottle liamcottle merged commit c1b29b2 into liamcottle:master Mar 21, 2023
@liamcottle
Copy link
Owner

Thanks! I've made a few changes and have merged this in. I'll get a new release sorted out later on. 🥳

@debagos
Copy link

debagos commented Mar 21, 2023

Hey nice work, but while testing this I got this error:

SyntaxError: Unexpected token '.'
camera.js:398
        return (this.cameraSubscribeInfo?.controlFlags & crosshairControlFlag) === crosshairControlFlag;
                                         ^

@liamcottle
Copy link
Owner

liamcottle commented Mar 21, 2023 via email

@debagos
Copy link

debagos commented Mar 21, 2023

Oh that was indeed the case, thank you @liamcottle 👍

@olijeffers0n olijeffers0n deleted the camera branch April 4, 2023 22:07
s8wa2 pushed a commit to s8wa2/rustplus.js-typed that referenced this pull request Apr 12, 2024
Implement PTZ Camera rendering and control
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

New camera update released
3 participants