Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Patch based on Manav Bhatia's for type-mixing methods #57

Merged
merged 1 commit into from
Mar 29, 2013

Conversation

roystgnr
Copy link
Member

scale_column is a generally useful method; the rest of these should make it easier to mix DenseVector/DenseMatirx objects of real and complex (or of float and double, etc) data types.

@buildhive
Copy link

libMesh - C++ Finite Element Library » libmesh #371 SUCCESS
This pull request looks good
(what's this?)

@roystgnr
Copy link
Member Author

That namespace isn't boost::, it's boostcopy:: - basically, years ago I swiped ~10 lines of boost metaprogramming code that I'd otherwise have had to reinvent or add a dependency for.

@pbauman
Copy link
Member

pbauman commented Mar 27, 2013

Derp. Cool, patch is fine with me then.

@roystgnr
Copy link
Member Author

Cool. Let's give folks a few days before merging this one, though. I want to see if Manav has any comment on that copy_matrix vs operator= question of mine, and it'd be good if people had a chance to test it with their app codes. Manav appears to have been quite careful to use the enable_if ad scalar traits stuff properly, but it's possible we're not seeing some flaw that could be triggered by just the right instantiation. IIRC the first time I tried to put some of this dual-templating stuff into our dense methods, the compiler initially decided that "vector * vector" should now be an outer product...

roystgnr added a commit that referenced this pull request Mar 29, 2013
Patch based on Manav Bhatia's for type-mixing methods
@roystgnr roystgnr merged commit 080f130 into libMesh:master Mar 29, 2013
@roystgnr roystgnr deleted the manav_dense_numerics branch March 29, 2013 22:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants