Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improved Singletons - Implements #64 #67

Merged
merged 3 commits into from
Mar 30, 2013
Merged

Conversation

benkirk
Copy link
Member

@benkirk benkirk commented Mar 29, 2013

After the discussion today I implemented Derek's idea with thread safety, and reimplemented RemoteElem on top of that. This should probably get pulled before the ReferenceElem business and I'll refactor that to use this.

Any issues?

Roy, what are your thoughts / issues regarding multiple LibMeshInit objects?

-Ben

@buildhive
Copy link

libMesh - C++ Finite Element Library » libmesh #391 SUCCESS
This pull request looks good
(what's this?)

@roystgnr
Copy link
Member

This looks good upon first skimming.

Mostly my concern regarding multiple LibMeshInit objects is that I'd like to make it easy to couple multiple libMesh-using codes together without them having to be too aware of each other, even in the case where they both think they're responsible for initializing libMesh and they're not passing the same MPI communicator in. This isn't a near-term plan, just something I'm trying to keep in mind lest we make any API changes that might preclude doing it in the long-term.

@buildhive
Copy link

libMesh - C++ Finite Element Library » libmesh #392 SUCCESS
This pull request looks good
(what's this?)

@benkirk
Copy link
Member Author

benkirk commented Mar 30, 2013

Merging this so I can rebase the ReferenceElem work off of it.

benkirk added a commit that referenced this pull request Mar 30, 2013
Improved Singletons - Implements #64
@benkirk benkirk merged commit dde02a2 into libMesh:master Mar 30, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants