Ignore clippy lint warning for derive default #334
Conversation
|
NOTE: The errors with clippy lint is unrelated to this change. A separate ticket/commit should be done for that. |
Yeah, I am working on that. It's caused by the new Rust release. |
There was a problem hiding this comment.
Looks good to me, @mimullin-bbry . Thanks! I am just wondering, why did you decide not add the allow annotation to the generated definition/impl directly but applied it to pretty much everything generated?
Because I didn't even think of that solution. What you describe is much much better and I'll see if I can implement it instead. |
Rust version 1.62 made it possible to use #[derive(Default)] on enums. (see: rust-lang/rust#94457) As of rust version 1.68, the default clippy configuration will print a warning for manually impl Derive on enums. As such, users of libbpf-cargo will begin to experience clippy warnings when they migrate to version 1.68. libbpf-cargo's minimum rust version is 1.58, thus the recommended method to remove the clippy warnings, is not yet an option for the project. Add a #[allow(clippy::derivable_impls)], to suppress the clippy warning on all generated skeletons. Add a TODO to remove this once the project moves to a minimum rust version of 1.62 Signed-off-by: Michael Mullin <[email protected]>
Rust version 1.62 made it possible to use #[derive(Default)] (see: rust-lang/rust#94457)
As of rust version 1.68, the default clippy configuration will print a warning for manually impl Derive on enums. As such, users of libbpf-cargo will begin to experience clippy warnings when they migrate to version 1.68.
libbpf-cargo's minimum rust version is 1.58, thus the recommended method to remove the clippy warnings, is not yet an option for the project.
Add a #[allow(clippy::derivable_impls)], to suppress the clippy warning on all generated skeletons.
Add a TODO to remove this once the project moves to a minimum rust version of 1.62
Signed-off-by: Michael Mullin [email protected]