Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add support for xmpp: uri in markdown syntax #500

Closed
goffi-contrib opened this issue Jan 8, 2017 · 3 comments
Closed

add support for xmpp: uri in markdown syntax #500

goffi-contrib opened this issue Jan 8, 2017 · 3 comments
Assignees

Comments

@goffi-contrib
Copy link

When adding and XMPP uri in the following form:
[[email protected]](xmpp:[email protected]?join)
the uri syntax is shown raw instead of linking to the room as expected.

@Changaco
Copy link
Member

Changaco commented Jan 9, 2017

Okay, so here's the Markdown situation:

We're currently using Misaka 1.0.2, an obsolete version based on the abandoned Sundown lib.

We have two possibilities:

According to this benchmark Mistune is around 20 times slower than Misaka, but it's pure python so there are no dependency issues, and it allows customizing the lexer in addition to the renderer (we don't need that feature right now though).

In both cases we need a Renderer subclass to sanitize links. We've been using the HTML_SAFELINK flag of Misaka 1, but Misaka 2 and Mistune don't have this feature built-in, and anyway we need to have sufficient control over the filter to allow XMPP links and close this issue.

@Changaco Changaco self-assigned this Jan 9, 2017
Changaco added a commit that referenced this issue Jan 9, 2017
Changaco added a commit that referenced this issue Jan 9, 2017
Changaco added a commit that referenced this issue Jan 9, 2017
@Changaco
Copy link
Member

Changaco commented Jan 9, 2017

I tried upgrading Misaka first and it worked so I went with that. See #502.

@goffi-contrib
Copy link
Author

That was quick, thanks :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

2 participants