Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add test for GH issue 1064, for 3.8 branch #1092

Closed
wants to merge 1 commit into from

Conversation

strk
Copy link
Member

@strk strk commented May 7, 2024

See GH-1064

@strk
Copy link
Member Author

strk commented May 7, 2024

No CI for 3.8 branch here ? What's the rationale of that ?

@strk strk force-pushed the gh1064-robust-relate branch from 1adac58 to fd27b11 Compare May 7, 2024 08:23
@strk strk changed the title Gh1064 robust relate Add test for GH issue 1064, for 3.8 branch May 7, 2024
@strk
Copy link
Member Author

strk commented May 7, 2024

CI runs but make check does not seem to be running any XML test

@strk
Copy link
Member Author

strk commented May 7, 2024

CI runs but make check does not seem to be running any XML test

I was wrong, it's just harder to spot them, but they are there:
https://github.com/libgeos/geos/actions/runs/8982102259/job/24668979871?pr=1092#step:4:6239

@strk strk marked this pull request as draft May 8, 2024 13:09
@strk
Copy link
Member Author

strk commented May 8, 2024

Expected result should be updated as reported in #1093 (comment)

@robe2
Copy link
Member

robe2 commented Aug 26, 2024

@strk Does this need to be added to other branches. GEOS 3.8 is EOL - https://libgeos.org/usage/download/

@pramsey
Copy link
Member

pramsey commented Sep 12, 2024

This PR should be closed as it adds a test that does not conform to what we think the answer should be, from discussion on GH-1064. Or it should be altered to have an answer that we agree with.

@pramsey pramsey closed this Oct 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants